From ec8cff15aca0beb595aba30a7d25c365751cb08a Mon Sep 17 00:00:00 2001 From: Pabloader Date: Tue, 12 May 2026 07:51:16 +0000 Subject: [PATCH] Remove stat set event --- src/common/rpg/components/stat.ts | 8 -------- test/common/rpg/stat.test.ts | 23 ----------------------- 2 files changed, 31 deletions(-) diff --git a/src/common/rpg/components/stat.ts b/src/common/rpg/components/stat.ts index 478fb32..a4e7400 100644 --- a/src/common/rpg/components/stat.ts +++ b/src/common/rpg/components/stat.ts @@ -42,19 +42,11 @@ export class Stat extends Component { @action set(value: number) { - const prev = this.value; this.state.base = value; - const next = this.value; - if (prev !== next) { - this.emit('set', { prev, value: next }); - } } applyModifier(delta: number, field: 'value' | 'max' | 'min' = 'value'): void { - const prev = this.value; this.state.modifierSums[field] += delta; - const next = this.value; - if (prev !== next) this.emit('set', { prev, value: next }); } removeModifier(delta: number, field: 'value' | 'max' | 'min' = 'value'): void { diff --git a/test/common/rpg/stat.test.ts b/test/common/rpg/stat.test.ts index 3c89886..7b9d5fc 100644 --- a/test/common/rpg/stat.test.ts +++ b/test/common/rpg/stat.test.ts @@ -109,29 +109,6 @@ describe('Stat — value / base / modifiers', () => { s.applyModifier(-100); expect(s.value).toBe(0); }); - - it("set() emits 'set' event with prev and value", () => { - const w = world(); - const e = w.createEntity(); - e.add(new Stat({ value: 10 }), 's'); - const s = e.get(Stat, 's')!; - const events: unknown[] = []; - e.on('Stat(s).set', ({ data }) => events.push(data)); - s.set(20); - expect(events).toEqual([{ prev: 10, value: 20 }]); - }); - - it("set() does not emit 'set' when value unchanged", () => { - const w = world(); - const e = w.createEntity(); - e.add(new Stat({ value: 10, min: 0 }), 's'); - const s = e.get(Stat, 's')!; - const events: unknown[] = []; - e.on('Stat(s).set', ({ data }) => events.push(data)); - s.set(-100); // clamped to 0, still changes - s.set(-200); // still 0, no change - expect(events.length).toBe(1); - }); }); describe('Health', () => {